fix(sdk): add shell option for Windows spawn compatibility#8162
Draft
jc01rho wants to merge 1 commit intoanomalyco:devfrom
Draft
fix(sdk): add shell option for Windows spawn compatibility#8162jc01rho wants to merge 1 commit intoanomalyco:devfrom
jc01rho wants to merge 1 commit intoanomalyco:devfrom
Conversation
On Windows, npm-installed packages create .cmd wrapper scripts. Node.js spawn() without shell: true cannot find these in PATH, causing ENOENT errors when spawning 'opencode'. This adds shell: true conditionally on Windows while maintaining Unix compatibility. Fixes anomalyco#8160
Contributor
|
The following comment was made by an LLM, it may be inaccurate: Potential Duplicate Found:
Reason for related flag: This PR appears to address the same Windows spawn ENOENT error issue that PR #8162 is fixing. Both target SDK compatibility with Windows |
opencode-agent
bot
force-pushed
the
dev
branch
from
00637c0 to
71e0ba2
Compare
thdxr
force-pushed
the
dev
branch
3 times, most recently
from
f1ae801 to
08fa7f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
shell: process.platform === 'win32'to bothspawn()calls in SDK server module.cmdwrappers aren't foundFixes #8160
Problem
On Windows, npm-installed packages create
.cmdwrapper scripts (e.g.,opencode.cmd). Node.jsspawn()withoutshell: truecannot find these in PATH, causing:Solution
Add conditional
shell: trueon Windows:Testing
Verified manually on Windows 11:
ENOENTerror when callingcreateOpencodeServer()Files Changed
packages/sdk/js/src/server.ts- both spawn callspackages/sdk/js/src/v2/server.ts- both spawn calls